[CALCITE-7498] The parser rejects the example hints from the documentation#4913
Merged
mihaibudiu merged 1 commit intoapache:mainfrom May 2, 2026
Merged
[CALCITE-7498] The parser rejects the example hints from the documentation#4913mihaibudiu merged 1 commit intoapache:mainfrom
mihaibudiu merged 1 commit intoapache:mainfrom
Conversation
…ation Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
caicancai
approved these changes
May 2, 2026
asolimando
approved these changes
May 2, 2026
Member
asolimando
left a comment
asolimando
left a comment
There was a problem hiding this comment.
LGTM, I miss in Java the equivalent of runnable examples from the doc like in Python or Rust, that would help catching regressions or implementation/doc drifts like in this case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7498
Changes Proposed
I have made the grammar a bit richer, accepting for for hints of the form
k=vboth strings and identifiers for values.I still had to rewrite the example, since the value cannot be just a numeric literal.